Am 25.03.2021 um 16:40 schrieb Gerhard Sittig:
>> Yes, the basic operation is fundamentally broken. The implementation
>> uses a construct of packed structs to layout USB reports. The packed
>> attribute is suppressed for some reasons in the MXE cross compile
>> configuration for the whole libsigrok project. This results in USB
>> reports for LA2016 with wrong content and length. The affected USB
>> reports are used to send essential parameters to the device. Therefore
>> the basic operation is fundamentalliy broken for at least one of the
>> supported platforms. There are some Git repositories around with
>> bugfixes including yours, Kevin's and mine. This is a good development,
>> but it's not available to the user who downloads an official version or
>> a nightly build.
> Are you, Helge and Kevin, talking about several different issues
> that are not related to each other?
>
> You can safely assume that I am aware of the USB transfers topic
> and the portability issues of packed structs, having been an
> active part in the communication about that. I remember having
> provided feedback on that, and having amended your submission to
> help make it acceptable. Haven't I, just in the very days that
> these messages were sent?

Kevin and I are talking about different things. I refer to the PulseView
version available to the normal user. If a Windows user wants to get the
software she downloads the installer from
https://sigrok.org/wiki/Downloads. This version of PulseView doesn't
work with the LA2016 at all.

There are several contributions with the driver and you finally created
a usable version that even fullfills style requirements. Thanks for
this! You find the working version as in the commits: c3d40037 and 955ab604.

PulseView 0.5.0 comes with a new great feature. The About dialog shows
the version information including the commit ID. When I built my
personal version I learned that you find the exact commit ID if the
libsigrok, that was used in the build.

The nightly build, downloaded on last Saturday March 27th (as well as
Monday April 5th), is the version 0.5.0-git-3ce5dd9. It includes the
libsigrok version 0.6.0-git-2111d15/4:0:0. Unfortunately this nightly
build is not built with your accepted version (955ab604). This might be
the reason why the software lists the LA-2016 but doesn't send any
request at the USB bus to the device.

I am not sure how the commits 955ab604 and 2111d15 are related. I can't
find the later in the libsigrok repository. So I can't even guess what's
wrong here. And I regret that I can't propose any step here.

I didn't download the the nightly day everyday. If my ovservations is
obsolute because of a nightly build from another commit is available,
please apologize this noise.

Best regards,
Helge



_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to