On 2021-04-06 09:40, Helge Kruse wrote:
Am 05.04.2021 um 16:54 schrieb Kevin Grant:
I have tested all this with LA2016 and LA1016 in PulseView on linux.
Sampling, edge/level triggering all work now. Perhaps others here can
verify that.
https://github.com/sigrokproject/libsigrok/pull/131
<https://github.com/sigrokproject/libsigrok/pull/131>
..or if you prefer a patch..
https://github.com/sigrokproject/libsigrok/pull/131.patch
<https://github.com/sigrokproject/libsigrok/pull/131.patch>
Hi Kevin,
many thanks for all the work on the Kingst LA devices. After adding
support for the LA-1016 I thought about the driver's name "LA-2016"
that
probably could be more generic. But since there are a lot of difference
device out there, it will be difficult to get a driver for all of them.
At least it would be expensive to test this with LA-5016, etc. ;-)
Hi Helge. I have local code to change the LA2016/LA1016 name in
PulseView dynamically as needed but did not included it in this PR,
which I wanted to keep minimal.
I don't intend to purchase an LA5016 but this driver would be a good
starting point for that I am sure.
I read the commit messages in the pull request #131:
2901085: add support for kingst la1016
The sigrok driver for the Kingst LA2016 is currently broken for many
use
cases, it doesn't work at all for me in PulseView.
This is a bit surprising, since I use the LA-2016 with my PulseView on
Windows 10. Was there something not working at all on Linux? At least I
using it (nearly) work-daily.
Because the fpga registers are being accessed incorrectly, users will
see varying degrees of "working" depending on particular capture
configuration (its a bit random).
Triggering and input threshold adjustment are always broken, the fpga
addresses are wrong.
These are cross-platform errors.
8e50232: fix segfault that often occurs when a capture is aborted
This commit does not belong to any branch on this repository.
All my commits for these changes are on the same new branch I created
for them. This is best practice IMHO?
https://github.com/Planet911/libsigrok/commits/kingst-la2016-driver-fixup
How do I abort or stop the capture in PulseView? Stopping the capture
manually after finding a reason is a desired feature.
Setup a long capture, say ten seconds or more. Before the capture ends
click the Run/Stop button. If I do this (on linux) I often get a
segfault. Now fixed with my commit.
I hope I will find time to build and test your modifications with my
environment. Especially the commit 4ce3361 "remove unnecessary
initialisation code" is very interesting. I though the omitted steps
can
be necessary after a power cycle. If you have a recommendation what I
should include in my test, I would like to follow the recommendation.
Best regards,
Helge
OK I will suggest some tests, with my results, in next few days.
Rgds
Kevin
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
