On 2021-04-05 15:54, Kevin Grant wrote:
Hello Gerhard,
The Kingst LA2016 driver needs some changes, as I summarised here:
https://sourceforge.net/p/sigrok/mailman/message/37249530/
Following on from that, here are a couple of pull requests.
(1) sigrok utils firmware extraction
The current firmware extraction script fails, probably due to a stream
name change by the vendor, within the resource file. Trivial fix.
I also altered the script slightly to extract more bitstreams, as they
are required by different variations of the LA2016 and its sibling, the
LA1016.
The crc32 of extracted files are now shown to help track vendor
changes. I added a README generated from the (updated) groff file.
https://github.com/sigrokproject/sigrok-util/pull/7
..or if you prefer a patch..
https://github.com/sigrokproject/sigrok-util/pull/7.patch
(2) LA2016 driver changes
These aren't huge changes but the details did take some time to work
out.
The main fix is addressing of configuration registers within the fpga,
for control of triggering, input thresholds and sampling.
I added support for the older LA2016 devices, and also LA1016 devices
which use the same hardware and operate similarly but need a different
fpga bitstream and run at reduced max sampling speed.
I added information on the fpga spi bus to the wiki, and along with
previous wiki changes and the schematic, I think the device information
is much improved and supports these changes.
I have tested all this with LA2016 and LA1016 in PulseView on linux.
Sampling, edge/level triggering all work now. Perhaps others here can
verify that.
https://github.com/sigrokproject/libsigrok/pull/131
..or if you prefer a patch..
https://github.com/sigrokproject/libsigrok/pull/131.patch
(3) The way forward
There is more work to be done on the driver to tidy things up a bit,
but this should at least enable full functionality for users.
Some things in PV need improved also; threshold voltage setting, and
limiting to one edge trigger only for these devices.
Regards
Kevin
Hello Gerhard,
I noticed a sigrok user gave positive feedback about my above pending
PRs
https://github.com/sigrokproject/libsigrok/pull/131#issuecomment-846534806
Regards
Kevin
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
