Am Samstag, 3. Dezember 2022, 08:22:43 CET schrieb Gerhard Sittig: > Thank you for that example data. Helped a lot. The point was to > make that very data available to those who review and later > maintain the software. That's why putting it into the commit > message when possible is so useful for awareness now and later.
If feasible I do that usually. Should have done it with the shortened example data as you did it now. > Should be fixed in e7ed37042611. Thanks for the quick action! > The implementation differs > though. Wanted to keep the set_analog_value() abstraction. Just removing "if (!value) return;" was my first local solution as well, but after further digging into the code I changed that because of two reasons (roughly mentioned in the last paragraph of my commit message): - I didn't want set_analog_value() to behave differently than set_logic_level(). - Clearing became needless and I wasn't sure about more fundamental changes. Removing the clearing from that function would leave the function name inadequate. > And > ignored the malloc0 change since it does not harm, and cost is > negligable (executes once per file import). The bug could have been spotted earlier, so I didn't consider that needless malloc0 to be that harmless and removed it. Markus _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
