On Wed, 2008-10-15 at 11:30 -0400, Damian Krzeminski wrote: > Dale Worley wrote: > > I've done some modifications of > > sipXconfig/web/src/org/sipfoundry/sipxconfig/site/tapestry.xml and > > checked them in as rev. 13706. A number of them are factoring out > > common regexp subexpressions as as XML entities, adding comments, etc. > > and shouldn't be controversial. > > > > But I did modify the "value" attribute/children of "property" entities > > to remove leading '^' and trailing '$' -- as far as I can tell, these > > patterns are implicitly anchored and ^/$ are redundant. However, if I'm > > wrong or this contravenes our style, please tell me and I'll update it. > > > > Dale > > > > > > Is it? > http://track.sipfoundry.org/browse/XCF-2910 > > Please make sure that you reference issue numbers when committing changes > in sipXconfig directory. > > Looks good, it was actually on my plate to be reviewed... (please set Patch > Pending state when submitting patches). > > Anchoring patters was probably left over from the previous version of > tapestry, which did not do that.
Sorry about that -- I entirely forgot there was an issue on the subject. Dale _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
