Dale Worley wrote: > On Wed, 2008-10-15 at 11:55 -0400, Damian Krzeminski wrote: >> Unfortunately I had to revert it for now since it was breaking several UI >> tests (which just might mean that the tests were wrong). >> Let's keep XCF-2910 till I have some time to review it and check those tests. > > I re-applied it in my working copy, and it seems to have passed the unit > tests. What errors do you see? > > I've attached the revised patch to XCF-2910 as patch2.diff. > > Dale > >
I have seen several UI test failures on my system and on a cruisecontrol build server (you need to run 'make precommit' to run DB, UI and integration tests - takes about 6 minutes on my machine): testcase: ListAcdServersTestUi -------------------------------------------------------------------------------- java.lang.AssertionError: User error: <Please enter valid DNS host name or IP address, for example server.domain.org, 10.1.1.25> testcase: DialPlanEditTestUi -------------------------------------------------------------------------------- junit.framework.AssertionFailedErrorjunit.framework.AssertionFailedError: Did not find form element with name [actionSelection]. testcase: DialingRuleTestUi -------------------------------------------------------------------------------- junit.framework.AssertionFailedErrorjunit.framework.AssertionFailedError: Did not find form element with name [selectGatewayModel]. testcase: GatewaysTestUi -------------------------------------------------------------------------------- java.lang.AssertionError: User error: <Please enter valid DNS host name or IP address, for example server.domain.org, 10.1.1.25> As I said - it might just mean that the tests are wrong - Kevin, Joe or I will straighten this out when we get to review the patch. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
