Dale Worley wrote: > On Thu, 2008-10-16 at 07:32 -0400, Damian Krzeminski wrote: >> I have seen several UI test failures on my system and on a cruisecontrol >> build server (you need to run 'make precommit' to run DB, UI and >> integration tests - takes about 6 minutes on my machine): > > It looks like "make precommit" only works in sipXconfig. > >> testcase: ListAcdServersTestUi >> -------------------------------------------------------------------------------- >> java.lang.AssertionError: User error: <Please enter valid DNS host name or >> IP address, for example server.domain.org, 10.1.1.25> >> >> testcase: DialPlanEditTestUi >> -------------------------------------------------------------------------------- >> junit.framework.AssertionFailedErrorjunit.framework.AssertionFailedError: >> Did not find form element with name [actionSelection]. >> >> testcase: DialingRuleTestUi >> -------------------------------------------------------------------------------- >> junit.framework.AssertionFailedErrorjunit.framework.AssertionFailedError: >> Did not find form element with name [selectGatewayModel]. >> >> testcase: GatewaysTestUi >> -------------------------------------------------------------------------------- >> java.lang.AssertionError: User error: <Please enter valid DNS host name or >> IP address, for example server.domain.org, 10.1.1.25> >> >> >> >> As I said - it might just mean that the tests are wrong - Kevin, Joe or I >> will straighten this out when we get to review the patch. > > I've looked at a couple of these, and they appear to be due to > one-component host names. E.g., "localhost2". The new patterns require > DNS names to have at least two components. > > Dale > >
I did not look but I suspect that in most if not all of those cases, there is no reason sipXconfig should reject just a hostname (and specifically 'localhost'). Note to myself (or whoever takes the patch): there should be a standard unit test for that pattern that verifies it. D. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev
