Quaker Fang wrote:
> webrev: http://cr.grommit.com/~zf162725/cr_0308/
> workspace & cscope: /net/greatwall.prc/workspace/wifi-wpa-cr/usr/src
>
> Please provide feedback to this list. The review timer is set for two
> weeks (03/22/2007).
> 2. DLPI related: 3 files, ~260 lines new
> l2_packet.[ch], ethernet.h
Here are my comments on DLPI related changes:
usr/src/uts/common/sys/ethernet.h
no comments.
usr/src/cmd/cmd-inet/usr.lib/wpad/l2_packet.h
* line39: since the ifname is used to open a DLPI linkname,
s/LIFNAMSIZ/DLPI_LINKNAME_MAX
usr/src/cmd/cmd-inet/usr.lib/wpad/l2_packet.c
* line 47: s/DLPI_SAP_ANY/DLPI_ANY_SAP, but just having an error message
"cannot bind on %s: %s" should suffice.
* line53: the comment doesn't match with the promiscous mode level.
s/DL_PROMISC_PHYS/DL_PROMISC_SAP
* line 56: error message might be better if "cannot enable promiscous
mode(SAP) on..."
* line 69: should be sizeof (l2->own_addr)
nits:
* line 50: remove extra line.
For consistency with error printing
* line 47,56: s/Cannot/cannot
* line 147: s/Unable/unable
Thanks,
Sagun
