Hi Sagun, Thanks for the review. Below is my response to your comments. Please let me know if you have any additional questions.
-- Quaker ===================================================== REVIEWER: Sagun.Shakya at Sun.COM WEBREV: http://cr.grommit.com/~zf162725/cr_0308/ FILES: DLPI related NOTES: Description of feedbacks: ACCEPT Request accepted REJECT Request rejected EXPLAIN Explanation given DISCUSS Request requires further discussion to resolve DEFER Request deferred (e.g. because work is out-of-scope) ===================================================== usr/src/uts/common/sys/ethernet.h no comments. usr/src/cmd/cmd-inet/usr.lib/wpad/l2_packet.h * line39: since the ifname is used to open a DLPI linkname, s/LIFNAMSIZ/DLPI_LINKNAME_MAX | ACCEPT usr/src/cmd/cmd-inet/usr.lib/wpad/l2_packet.c * line 47: s/DLPI_SAP_ANY/DLPI_ANY_SAP, but just having an error message "cannot bind on %s: %s" should suffice. | ACCEPT * line53: the comment doesn't match with the promiscous mode level. s/DL_PROMISC_PHYS/DL_PROMISC_SAP | ACCEPT | The comment is wrong, removed. * line 56: error message might be better if "cannot enable promiscous mode(SAP) on..." | ACCEPT * line 69: should be sizeof (l2->own_addr) | ACCEPT nits: * line 50: remove extra line. | ACCEPT For consistency with error printing * line 47,56: s/Cannot/cannot * line 147: s/Unable/unable | ACCEPT Besides, the change webrev is at: http://cr.grommit.com/~zf162725/cr_0328/
