Great changes.
--- a/src/backends/firebird/row-id.cpp
+++ b/src/backends/firebird/row-id.cpp
@@ -18,6 +18,4 @@ firebird_rowid_backend::firebird_rowid_backend(firebird_sessio
firebird_rowid_backend::~firebird_rowid_backend()
{
- // Unsupported in Firebird backend
- throw soci_error("RowIDs are not supported");
}
Nice catch.
--- a/src/backends/mysql/statement.cpp
+++ b/src/backends/mysql/statement.cpp
@@ -377,10 +377,8 @@ void mysql_statement_backend::describe_column(int colNum,
case FIELD_TYPE_CHAR: //MYSQL_TYPE_TINY:
case FIELD_TYPE_SHORT: //MYSQL_TYPE_SHORT:
case FIELD_TYPE_INT24: //MYSQL_TYPE_INT24:
- type = dt_integer;
- break;
case FIELD_TYPE_LONG: //MYSQL_TYPE_LONG:
- type = field->flags & UNSIGNED_FLAG ? dt_unsigned_long : dt_integer;
+ type = dt_integer;
break;
This will break test9 in test-mysql.cpp. Instead please use
case FIELD_TYPE_CHAR: //MYSQL_TYPE_TINY:
case FIELD_TYPE_SHORT: //MYSQL_TYPE_SHORT:
case FIELD_TYPE_INT24: //MYSQL_TYPE_INT24:
type = dt_integer;
break;
case FIELD_TYPE_LONG: //MYSQL_TYPE_LONG:
type = field->flags & UNSIGNED_FLAG ? dt_long_long : dt_integer;
break;
Other than that, looks good to me.
Thanks,
Aleksander
On Fri, Jul 6, 2012 at 4:48 PM, Vadim Zeitlin <vz-s...@zeitlins.org> wrote:
> Hello,
>
> I've finally cleaned up the changes I did locally and pushed them out to
> the "proposed" branch of my Github SOCI repository. You can easily see all
> the changes at
>
> https://github.com/vadz/soci-experiments/compare/master...proposed
>
> Unfortunately the web interface doesn't have "git glog" equivalent (or I
> couldn't find it) but the "proposed" branch is actually a combination of 3
> other branches which are also in the same repository: "firebird-fixes",
> "odbc-fixes", "sequences", which can all be reviewed separately in the
> same repository, plus some individual commits. These changes cover all the
> enhancements/fixed discussed on this list since May. Firebird and ODBC
> fixes should be uncontroversial and nobody objects much against adding
> sequences support, but please do look at x_unsigned_long removal and
> unsigned types handling changes if you have any questions/doubts about
> them.
>
> To summarize, if you're only interested in ODBC changes you could review
> just the odbc-fixes branch. And if you're only interested in looking at the
> new API additions, you could look at "sequences". But ideal would be to
> have a look at all of the changes.
>
>
> You can leave the comments on the commits directly in the Github web
> interface but you'd probably still want to pull this branch locally in
> order to test it with your code.
>
>
> If nothing turns out to be horribly broken by these changes, I'd like to
> commit them the next week as I'll be on vacation afterwards. So please let
> me know if anything is.
>
> Thanks in advance for any comments,
> VZ
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Soci-users mailing list
> Soci-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/soci-users
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Soci-users mailing list
Soci-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/soci-users
