Hello Vadim, I'm curious, why did you decide not to use the code I suggested for backends/mysql/statement.cpp? All of FIELD_TYPE_CHAR, FIELD_TYPE_SHORT and FIELD_TYPE_INT24 should fit in four bytes no matter whether they're signed or unsigned, so why not just identify them as dt_integer? The only type which needs to be long long when unsigned is FIELD_TYPE_LONG. There is no test for this but I suspect your version will break some code which uses row->get<int>() for retrieving a column of type say SMALLINT UNSIGNED.
Do you have any objection to me changing it to the version I proposed in this thread? Thanks, Aleksander On Tue, Jul 10, 2012 at 1:45 PM, Vadim Zeitlin <vz-s...@zeitlins.org> wrote: > Hello again, > > I've committed all the previously mentioned changes, please post any new > bugs/regressions here and I'll try to address them. > > Thanks, > VZ > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Soci-users mailing list > Soci-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/soci-users > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Soci-users mailing list Soci-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/soci-users
