On Sun, 8 Jul 2012 13:31:46 -0700 Pawel Aleksander Fedorynski 
<pfe...@gmail.com> wrote:

PAF> --- a/src/backends/mysql/statement.cpp
PAF> +++ b/src/backends/mysql/statement.cpp
PAF> @@ -377,10 +377,8 @@ void mysql_statement_backend::describe_column(int 
colNum,
PAF>      case FIELD_TYPE_CHAR:       //MYSQL_TYPE_TINY:
PAF>      case FIELD_TYPE_SHORT:      //MYSQL_TYPE_SHORT:
PAF>      case FIELD_TYPE_INT24:      //MYSQL_TYPE_INT24:
PAF> -        type = dt_integer;
PAF> -        break;
PAF>      case FIELD_TYPE_LONG:       //MYSQL_TYPE_LONG:
PAF> -        type = field->flags & UNSIGNED_FLAG ? dt_unsigned_long : 
dt_integer;
PAF> +        type = dt_integer;
PAF>          break;
PAF> 
PAF> This will break test9 in test-mysql.cpp. 

 Sorry about this, I hadn't built MySQL backend initially as I didn't have
the right libraries installed and completely forgot to rebuild with MySQL
backend before submitting the patches :-( I've done this now and corrected
the code as you suggested, thanks for noticing this!

PAF> Other than that, looks good to me.

 Thanks a lot for the review!
VZ

Attachment: pgpqjOB4dGAsV.pgp
Description: PGP signature

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Soci-users mailing list
Soci-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/soci-users

Reply via email to