Oliver Hartkopp wrote: > Wolfgang Grandegger wrote: >> Hi Oliver, >> >> Oliver Hartkopp wrote: > >>> Hi all, >>> >>> i updated the SVN and introduced a new GET_CAN_DLC() macro, that casts the >>> data length code information to __u8 and ensures the dlc not to be > 8 . >> I like your approach. I'm just not happy with the name. We should use >> the prefix "can_" for public functions and lower-case seems also more >> appropriate. A "static inline" is less handy, I agree. Therefore I vote >> for "can_get_dlc()". Also some description for that macro would be nice. > > No problem. > > So you would suggest to s/GET_CAN_DLC/can_get_dlc/g to rename the macro, > right?
Well, yes, also "get_can_dlc" would be fine as we already have alloc_candev, etc. Thanks, Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
