[
https://issues.apache.org/jira/browse/SOLR-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620078#action_12620078
]
Henri Biestro commented on SOLR-545:
------------------------------------
Not knowing how advanced Ryan is on solving the whole issue, I might be
completely off-base...
As far as I remember, we had a "default" attribute that could be applied to one
core (in the multicore case); this part is gone.
The current SolrDispatchFilter behavior is to let the filter chain handle any
URL that is not a request that solr can recognize as valid. We may add as a
default that the chain ends in 404 in the 'unhandlable' case but that default
fall through behavior should remain opened/overridable (multiple core
spanning/joining requests could be handled in another filter for instance).
If we treat single core as multicore with only one core AND there is no default
core:
The current test for what would be that "single-core" multicore situation looks
like (multicore == null || multicore.isEnabled() == false); the ability to let
users derive MultiCore (for serialization purpose at least) and let them
allocate it (through SolrDispatchFilter.initMultiCore()) should be kept (we are
trying to avoid reintroducing a singleton here).
If so & as is, this "single-core" multicore can not (should not be able to?)
create new cores (nor can it swap cores since it can't create a new one) and
probably should not attempt to read the multicore.properties (by-product of
solr-646); this implies some new checks must be performed at the multicore
level & dealing with a 'null' core name will still have to be considered &
tested.
The risk - with my current understanding/knowledge - does not seem worth the
(shallow) gain.
Back to the issue description:
"MultiCore should require a core name in the URL; If the core name is missing,
there should be a 404": +1 as long as this can be changed ("not a valid core"
is already out of the equation)
"...treat single core as multicore with only one core? As is the tangle of
potential paths is ugly..": although the code is more complex than we'd like
(at least the SolrDispatchFilter code), it is fairly well documented and I'm
not completely sure there is a lot to gain (considering the null core name &
1.3 delays and that the simplest action could be to deprecate "single core"
altogether). So, -1
> remove MultiCore "default" core / cleanup DispatchHandler
> ---------------------------------------------------------
>
> Key: SOLR-545
> URL: https://issues.apache.org/jira/browse/SOLR-545
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
>
> MultiCore should require a core name in the URL. If the core name is
> missing, there should be a 404, not a valid core. That is:
> http://localhost:8983/solr/select?q=*:* should return 404.
> While we are at it, we should cleanup the DispatchHandler. Perhaps the best
> approach is to treat single core as multicore with only one core? As is the
> tangle of potential paths is ugly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
