[
https://issues.apache.org/jira/browse/SOLR-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621190#action_12621190
]
Henri Biestro commented on SOLR-545:
------------------------------------
Ryan, glad I could. :-)
On solr-647, or more precisely "The SolrDispatchFilter (& EmbeddedSolrServer)
need to protect against core closing while queries are executing", should we
then create another specific issue (solved in the 1.3 timeframe) ?
On solr-545 itself, I agree your solution is better & simpler than introducing
the 'strict' parameter.
One comment, shouldn't the deprecated servlet check for the existence of the
'org.apache.solr.MultiCore' request attribute though?
You can instantiate multicore in other/derived ways through the servlet filter
& could still inadvertently go through the servlet.
On the "crazy path checking", I'm currently trying to refactor/merge
SolrDipatchFilter & EmbeddedSolrServer to both derive from one "SolrFilter" .
Tell me if this is a bad idea or if this should be also another issue (that
could be fixed later than 1.3).
Thanks
> remove MultiCore "default" core / cleanup DispatchHandler
> ---------------------------------------------------------
>
> Key: SOLR-545
> URL: https://issues.apache.org/jira/browse/SOLR-545
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-545-path-access.patch, solr-545.patch,
> solr-545.patch, solr-545.patch, solr-545.patch
>
>
> MultiCore should require a core name in the URL. If the core name is
> missing, there should be a 404, not a valid core. That is:
> http://localhost:8983/solr/select?q=*:* should return 404.
> While we are at it, we should cleanup the DispatchHandler. Perhaps the best
> approach is to treat single core as multicore with only one core? As is the
> tangle of potential paths is ugly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
