[ 
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625277#action_12625277
 ] 

Shalin Shekhar Mangar commented on SOLR-724:
--------------------------------------------

I think you mean get/set coreProperties.

I don't think there's a problem. These methods can continue to be used for 
properties (evaluated expressions). We can always keep another object for 
un-evaluated expressions for persisting them back.

> CoreDescriptor.{get,set}CoreExpressions should probably not be public (but 
> package private)
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-724
>                 URL: https://issues.apache.org/jira/browse/SOLR-724
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>            Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with 
> property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to