[ 
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625289#action_12625289
 ] 

Noble Paul commented on SOLR-724:
---------------------------------

bq.I'm just trying to reduce public method exposure. 

There is no harm is exposing methods as long as we are exposing immutable 
stuff. It can actually enable a lot of components to get information w/o 
raising new issues in JIRA

> CoreDescriptor.{get,set}CoreProperties should probably not be public (but 
> package private)
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-724
>                 URL: https://issues.apache.org/jira/browse/SOLR-724
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>            Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with 
> property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to