[ 
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625346#action_12625346
 ] 

Henri Biestro commented on SOLR-724:
------------------------------------

When a method is public, it also has to be maintained & up-compatible; if you 
write a component that uses some private methods or members, that's your 
prerogative but there is no guarantee from Apache that it's existence and 
behavior will remain in the future.
In this issue, I'm stating that exposing Properties in the CoreDescriptor is 
hindering future evolution because they will have to be maintained, that the 
same information should be available from what I consider a narrower scope 
location that does not reduce the  functional possibilities.



> CoreDescriptor.{get,set}CoreProperties should probably not be public (but 
> package private)
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-724
>                 URL: https://issues.apache.org/jira/browse/SOLR-724
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>            Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with 
> property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to