[
https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625369#action_12625369
]
Shalin Shekhar Mangar commented on SOLR-724:
--------------------------------------------
I feel that CoreContainer and CoreDescriptor seem to be the most logical place
to *find* the properties since they directly correspond to the <solr> and
<core> elements in solr.xml and SolrResourceLoader is the most logical place to
*use* them since that's what we use to load config files. I think it should be
OK to keep both the ways.
Thoughts?
> CoreDescriptor.{get,set}CoreProperties should probably not be public (but
> package private)
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-724
> URL: https://issues.apache.org/jira/browse/SOLR-724
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Henri Biestro
> Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with
> property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
