[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671644#action_12671644
]
Jared Flatow commented on SOLR-993:
-----------------------------------
bq. can I add a name with '.' (dot) in the end? . I guess it should be possible
Yeah, so: <word>.<another_word>.<one_more_word> will always do a hierarchical
lookup. But if you have something like
<word>.<another_word>.function(<another_namespace>, <another_namespace>, etc.),
the last part unambiguously refers to a function because of the non-word
characters (the parenthesis, commas, spaces). I think that is a reasonable
definition, but you can always expand the class of word characters a little to
include things like '/', ':', and '#'.
bq. so , what should be the behavior? if I add a namespace "c.d" to "a.b" it
should create a new namespace "c" inside "b" and put "d" into it? if we do not
do that it is still possible to have ambiguity.
I think if you add 'c.d' as a key of a mapping into the namespace 'a.b', the
only way to resolve it should be to get the 'a.b' namespace and then get the
key 'c.d' (i.e. the same behavior for putting it in as for taking it out).
Presumably if you are putting '.' into your key names you are asking for
trouble, but the behavior is actually unambiguous. If you want to have a value
'd' in namespace 'a.b.c', then you should add to the 'a.b.c' namespace in the
first place. If you add 'c.d' to 'a.b', then thats what you will end up with
(i.e., there is no namespace 'a.b.c.d', only 'a.b' with a key 'c.d').
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
