[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671756#action_12671756
]
Shalin Shekhar Mangar commented on SOLR-993:
--------------------------------------------
Jared, can you please update the patch for trunk? I couldn't apply the patch. I
think the path is not correct or there is a conflict.
bq. It should, and at least for the formatDate format string, it does. Which
function are you using to test?
{code}
for (String part : splitName(variable)) {
value = namespace.get(part);
namespace = (value instanceof Map) ? (Map) value :
Collections.EMPTY_MAP;
}
{code}
I did not apply the patch but I was looking at the above code. We are splitting
by '.' and going into each map we find. Will this reach upto a '.' character in
a float or string value given as a parameter to a function?
I think we should take a step back here. What is it that you are trying to
achieve? There are multiple things that you are trying to address:
# addToNamespace method in variable resolver
# Change behavior of variable resolver (why? not very clear to me). In this
process we are changing working code and disallowing some characters from
appearing in variable names (\\w means no hyphens etc.) and no '.' in dynamic
maps. These are not big changes but I want to understand why we need these
changes?
It is better to focus on one issue at a time. Let us use this issue for the
addToNamespace method which we all agree to be useful. Let us create another
issue for the discussion on the behavior of variable resolver.
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
