[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671657#action_12671657
]
Noble Paul commented on SOLR-993:
---------------------------------
bq.Yeah, so: <word>.<another_word>.<one_more_word> will always do a
hierarchical lookup
In the current implementation , it is not 'always' a hierarchical lookup. I
guess it is useful that way.
bq.I think if you add 'c.d' as a key of a mapping into the namespace 'a.b', the
only way to resolve it should be to get the 'a.b' namespace and then get the
key 'c.d' (i.e. the same behavior for putting it in as for taking it out ....
invoking variableresolver thru an API is not the most common usecase. When a
variable is resolved , I wish the behavior to be intuitive. if someone puts a
leaf value with "c.d " in the namespace "a.b" I wish it to fetch the actual
value of "c.d" (which it does currently) . If he also has a namespace called
"c" inside "a.b" then there is ambiguity , but that is less common and the
current behavior seems to be OK.
What you are asking now is to change the current behavior of VariableResolver
in a non-backcompat way and I cannot see the value. I agree with adding the
method addToNameSpace() . But , I am not comfortable changing the way the
lookup is done.
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
