[
https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671742#action_12671742
]
Shalin Shekhar Mangar commented on SOLR-993:
--------------------------------------------
bq. Are there any cases of dynamic maps right now that don't look like function
calls?
No but do remember that VariableResolver is agnostic of functions. They are
resolved just like any other variable.
bq. Is it unreasonable to say you can't use '.' characters in naming those
functions? If you really want to call "a.b.c.d.e(...)", then have your dynamic
namespace be "a.b.c.d" with a function "e(...)".
I guess not.
bq. WRT iterating over the maps: to be clear, I would prefer the implementation
be changed to how the patch is now
We need to change the patch slightly. In particular, the way the resolve method
is implemented, it won't work with passing float values or a string containing
'.' to a function.
Please ignore the comment about false alarms. I'm fine with the idea of logging
failures in resolving variables.
> VariableResolverImpl addNamespace overwrites entire namespace instead of
> adding
> -------------------------------------------------------------------------------
>
> Key: SOLR-993
> URL: https://issues.apache.org/jira/browse/SOLR-993
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: Jared Flatow
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-993.patch, SOLR-993b.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the
> namespace as overwrite it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
