On 07/28/2009 03:53 PM, Joshua Roys wrote:
Hello,
Attached is a version rebased on latest master and taking into account
the recent postgresql changes.
Thanks,
Joshua Roys
I reviewed the code and Overall it looks good. Seeing minor issues
such as test build failures and checkstyle.
If you run
$ ant clean all (in java dir) you should see,
do-compile-main:
[javac] Compiling 2469 source files to
code/git/spacewalk/java/build/classes
[javac]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/test/ConfigurationFactoryTest.java:153:
lookupOrInsertConfigInfo(java.lang.String,java.lang.String,java.lang.Long,java.lang.String)
in com.redhat.rhn.domain.config.ConfigurationFactory cannot be applied
to (java.lang.String,java.lang.String,java.lang.Long)
[javac] ConfigInfo info1 =
ConfigurationFactory.lookupOrInsertConfigInfo("testman",
[javac] ^
[javac]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/test/ConfigurationFactoryTest.java:155:
lookupOrInsertConfigInfo(java.lang.String,java.lang.String,java.lang.Long,java.lang.String)
in com.redhat.rhn.domain.config.ConfigurationFactory cannot be applied
to (java.lang.String,java.lang.String,java.lang.Long)
[javac] ConfigInfo info2 =
ConfigurationFactory.lookupOrInsertConfigInfo("testman",
[javac] ^
[javac]
code/git/spacewalk/java/code/src/com/redhat/rhn/testing/ConfigTestUtils.java:310:
lookupOrInsertConfigInfo(java.lang.String,java.lang.String,java.lang.Long,java.lang.String)
in com.redhat.rhn.domain.config.ConfigurationFactory cannot be applied
to (java.lang.String,java.lang.String,java.lang.Long)
[javac] return
ConfigurationFactory.lookupOrInsertConfigInfo(user, group, fileMode);
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 3 errors
BUILD FAILED
For checkstyle Errors:
run $ ant checkstyle (in your java dir) and you'll see,
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/ConfigInfo.java:107:19:
Name 'getSelinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/ConfigInfo.java:115:17:
Name 'setSelinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/ConfigurationFactory.java:483:53:
Name 'selinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/domain/config/ConfigurationFactory.java:498:35:
Name 'selinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/manager/configuration/file/ConfigFileData.java:140:19:
Name 'getSelinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/manager/configuration/file/ConfigFileData.java:147:17:
Name 'setSelinux_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[checkstyle]
code/git/spacewalk/java/code/src/com/redhat/rhn/manager/configuration/file/ConfigFileData.java:254:39:
'(' is followed by whitespace.
BUILD FAILED
Mind fixing those and including it in your patch? In the mean time I'm
trying to deploy your patch to a test server and testing it.
Thanks again,
~ Prad
------------------------------------------------------------------------
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
--
--
Pradeep Kilambi
RHN Satellite Engineering
[email protected]
Phone: +1 919 754 4285
RHCE # 805008680430554
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
