On 07/30/2009 05:11 PM, Pradeep Kilambi wrote:
On 07/30/2009 04:42 PM, Joshua Roys wrote:
Hello,
How strange, I did somehow completely delete that from all copies of
my code... luckily it's actually one line.
from selinux import setfilecon
And now the package that file is in will depend on libselinux-python,
if it doesn't already.
Sorry about that.
I'll try to address the issues you've found and produce a more
official patch tomorrow.
Joshua Roys
No Problem. I'll wait for your final patch and retest it. I have all
your code deployed and setup so its gonna be a quick test this time.
Thanks again for your contribution.
~ Prad
Also few suggestions looking through the behaviour after fixing that one
line:
* If we set an invalid content for a file, setfilecon will return a -1
and leave the default context. I would check if the return code of
setfilecon is -1 and log that info so user knows that the context dint
apply in failure case.
* Secondly in the fileDetails.do page, below the selinux Content entry
area, I would add a tip to help users know the format of the input that
field takes.
Thanks,
~ Prad
--
--
Pradeep Kilambi
RHN Satellite Engineering
[email protected]
Phone: +1 919 754 4285
RHCE # 805008680430554
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
