On 07/28/2009 03:53 PM, Joshua Roys wrote:
Hello,

Attached is a version rebased on latest master and taking into account the recent postgresql changes.

Thanks,

Joshua Roys

Joshua:

Seeing more issues,

- If you try to deploy a file with a content it hits the below block.

D: do_call configfiles.deploy ({'files': [{'config_channel': 'pradtest', 'username': 'root', 'md5sum': '71b517126a29976c78b478065104bc04', 'encoding': 'base64', 'filetype': 'file', 'delim_start': '{|', 'file_contents': 'aGkgc2VsaW51eA==\n', 'groupname': 'root', 'delim_end': '|}', 'selinux_ctx': 'user_home_t', 'filemode': 644, 'path': '/tmp/foo.txt', 'revision': 2}]},)
global name 'setfilecon' is not defined
D: Sending back response (49, "Failed deployment, rolled back: global name 'setfilecon' is not defined", {})
D: do_call packages.checkNeedUpdate ('rhnsd=1',)
D: local action status: (0, 'rpm database not modified since last update (or package list recently updated)', {})
D: closed   db index       /var/lib/rpm/Providename
D: closed   db index       /var/lib/rpm/Packages
D: closed   db environment /var/lib/rpm/Packages
D: May free Score board((nil))


diff --git a/client/tools/rhncfg/config_common/transactions.py b/client/tools/rhncfg/config_common/transactions.py
index 9f87700..2458f9a 100644
--- a/client/tools/rhncfg/config_common/transactions.py
+++ b/client/tools/rhncfg/config_common/transactions.py
 ...
+            if file_info.has_key('selinux_ctx'):
+                sectx = file_info.get('selinux_ctx')
+                if sectx is not None:
+                    log_debug(1, "selinux context: " + sectx);
+                    setfilecon(temp_file_path, sectx);
+
...

In the above block setfilecon here is not defined, so it will fail with a global setfilecon not set. Looks like you left out parts in your patch that is suppose to set the content of the file once the client gets the request.

~ Prad




------------------------------------------------------------------------

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel


--
--
Pradeep Kilambi
RHN Satellite Engineering
[email protected]
Phone: +1 919 754 4285
RHCE # 805008680430554


_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to