On 07/31/2009 02:28 PM, Joshua Roys wrote:
On 07/30/2009 05:24 PM, Pradeep Kilambi wrote:
Also few suggestions looking through the behaviour after fixing that one
line:
* If we set an invalid content for a file, setfilecon will return a -1
and leave the default context. I would check if the return code of
setfilecon is -1 and log that info so user knows that the context dint
apply in failure case.
* Secondly in the fileDetails.do page, below the selinux Content entry
area, I would add a tip to help users know the format of the input that
field takes.
Thanks,
~ Prad
Hello,
Thanks for taking a look at this! Suggestions applied. Attached are
two patches - the full one from master, and an 'update' diff from the
previously sent patch.
Thanks again,
Joshua Roys
Hello Joshua:
This final version looks good. config files deployed with correct
selinux content for me. Thanks for including all the suggestion. Patches
tested and applied.
New commits:
commit 40785d998874d7e9b022a79a8322bce09af8ac3f
Author: Joshua Roys<[email protected]>
Date: Mon Aug 3 13:21:21 2009 -0400
Patch: Selinux Context support for config files
commit 074cca0508e8d6b4817453f45b2bfada62ed8623
Author: Joshua Roys<[email protected]>
Date: Mon Aug 3 13:25:08 2009 -0400
upgrade script for the previous commit. Patch from Joshua Roys
Thanks a lot for your contribution.
~ Prad
--
--
Pradeep Kilambi
RHN Satellite Engineering
[email protected]
Phone: +1 919 754 4285
RHCE # 805008680430554
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
