On 08/25/2011 07:10 PM, Bo Maryniuk wrote: > I thought the patches reviews you, guys, doing are more than just > works/not-works?
Not exactly. This is true for small bugs. E.g there is some bug in Spacewalk. Somebody diagnose it, create patch and sent it here (unless he is proved Spacewalk contributor and has git access). We review it and if it works, we commit it. But even then we often fix some code style. Trim trailing whitespaces, wrap lines... etc. But if it is feature, then we try to public face it as much and as soon as possible. And we try to find solution which is as generic as possible and which will be maintainable even few years from now. I have to admit that we discuss some things internally in our cubicle as RH developers sits in one room, but when we are not lazy we post it to mailing list to get feedback from others as well. Debian support and PostgreSQL support comes to my mind as good example where we discussed our progress during our work. -- Miroslav Suchy Red Hat Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
