----- Original Message ----- > > Hello, > Please find attached a proposed patch for this. > I've added database.control boolean directly in rhn.conf file. > I've modified the spacewalk-service script to manage this parameter.
There is several problems with your patch. 1) It is much better to generate it using git format-patch, rather then git log -p https://fedorahosted.org/spacewalk/wiki/GitGuide#SubmittingPatches 2) Try what will happen if you will have in rhn.conf: #comment it for now #database.control = 1 3) /etc/init.d/postgresql This is not true any more in Fedora 16. See section 3.7.2 of: http://docs.fedoraproject.org/en-US/Fedora/16/html/Release_Notes/sect-Release_Notes-Changes_for_Sysadmin.html 4) [[ is IMHO unnecessary bashism, [ will work as well and it will work outside of bash too. BTW: are you subscribed to spacewalk-devel mailing list? It will be more appropriate to discuss it there. Mirek _______________________________________________ Spacewalk-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-list
