I'll switch to spacewalk-devel list on monday, I have to subscribe. 1) Sorry, I used git diff and not format-patch 2) You're right, I'll correct it, I don't check if the line is commented out. 3) I'll try to find the best way to detect if systemd is used or not. I don't have a F16 box, so a few questions: - How is postgresql controlled with systemd: postgresql start and stop? - Is postgresql the only software that is integrated with systemd in spacewalk? 4) OK, I'll correct this too
PIerre 2011/11/12 Miroslav Suchy <[email protected]> > ----- Original Message ----- > > > > Hello, > > Please find attached a proposed patch for this. > > I've added database.control boolean directly in rhn.conf file. > > I've modified the spacewalk-service script to manage this parameter. > > There is several problems with your patch. > > 1) It is much better to generate it using git format-patch, rather then > git log -p > https://fedorahosted.org/spacewalk/wiki/GitGuide#SubmittingPatches > > 2) Try what will happen if you will have in rhn.conf: > #comment it for now > #database.control = 1 > > 3) /etc/init.d/postgresql > This is not true any more in Fedora 16. See section 3.7.2 of: > > http://docs.fedoraproject.org/en-US/Fedora/16/html/Release_Notes/sect-Release_Notes-Changes_for_Sysadmin.html > > 4) [[ is IMHO unnecessary bashism, [ will work as well and it will work > outside of bash too. > > BTW: are you subscribed to spacewalk-devel mailing list? It will be more > appropriate to discuss it there. > > Mirek > > _______________________________________________ > Spacewalk-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-list >
_______________________________________________ Spacewalk-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-list
