On (09/06/16 14:39), Pavel Březina wrote: >On 06/08/2016 02:20 PM, Petr Cech wrote: >> On 05/31/2016 02:42 PM, Pavel Březina wrote: >> > On 05/30/2016 05:49 PM, Petr Cech wrote: >> > > On 05/30/2016 10:42 AM, Pavel Březina wrote: >> > > > On 05/27/2016 04:32 PM, Petr Cech wrote: >> > > > > Hi, >> > > > > >> > > > > I have new version of this patch set. >> > > > > I fixed CI tests on debian [1]. My thanks belongs to Lukas and >> > > > > Nikolai. >> > > > > >> > > > > >> > > > > [1] http://sssd-ci.duckdns.org/logs/job/44/04/summary.html >> > > > > >> > > > > >> > > > > Regards >> > > > >> > > > Ack to the patches, I'm running CI now. The only thing I'm worried >> > > > about >> > > > is that we're using blocking calls getpwnam_r and similar. We >> > > > already do >> > > > this on some parts of sssd but looking into the cases it's either >> > > > initialization or a very rare condition or a data provider. >> > > > >> > > > Here we block for every local object and since this is an NSS responder >> > > > I think we should create a non-blocking way rather sooner than >> > > > later. It >> > > > will be for free when sssd will manage local users though so I'm not >> > > > sure if it's worth the work. >> > > > >> > > > >> > > > >> > > > >> > > >> > > Hi Pavel, >> > > >> > > thanks for review. >> > > I know that CI tests failed [1]. >> > > Actually this CI tests passed [2]. >> > > >> > > >> > > [1] http://sssd-ci.duckdns.org/logs/job/44/05/summary.html >> > > [2] http://sssd-ci.duckdns.org/logs/job/44/07/summary.html >> > >> > With your patches, two tests sometimes fails and sometimes not. With >> > master it seems to always succeed. >> > >> > [1] http://sssd-ci.duckdns.org/logs/job/44/05/summary.html >> > ldap_test.py::test_add_remove_group_rfc2307 PASSED >> > ldap_test.py::test_add_remove_group_rfc2307_bis FAILED >> > >> > [2] http://sssd-ci.duckdns.org/logs/job/44/08/summary.html >> > ldap_test.py::test_add_remove_group_rfc2307 FAILED >> > ldap_test.py::test_add_remove_group_rfc2307_bis PASSED >> > >> > I do not know whether it is related to your patches or it is a random >> > bug. >> >> Hi Pavel, >> >> I think this is not related to my patch. > >Me as well. Feel free to push it. > master: * d9e88bddc99bae0542b2179c9b94c968855b0fd0 * e7ccfb139388c947ec2dee16cfe3005f5643b90d
LS _______________________________________________ sssd-devel mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
