On Thu, 9 Jun 2011 20:05:18 +0200 Mathias Krause <[email protected]> wrote:
> Subject: [PATCH] exec: delay address limit change until point of no return > > Unconditionally changing the address limit to USER_DS and not restoring > it to its old value in the error path is wrong because it prevents us > using kernel memory on repeated calls to this function. This, in fact, > breaks the fallback of hard coded paths to the init program from being > ever successful if the first candidate fails to load. > > With this patch applied switching to USER_DS is delayed until the point > of no return is reached which makes it possible to have a multi-arch > rootfs with one arch specific init binary for each of the (hard coded) > probed paths. > > Since the address limit is already set to USER_DS when start_thread() > will be invoked, this redundancy can be safely removed. A couple of things here, please. The description doesn't describe the user-visible symptoms of the bug. This makes it hard for the -stable maintainers to work out whether they should accept the patch and it makes it hard for random distro maintainers to determine whether your patch might fix a user bug report which they're working on. Secondly, I understand that we have identified changes which other arch maintainers should make and test. Please describe those changes to make it easy for them and please also describe a way in which they can test that change. Both these things could be addressed using a description of some testcase. _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
