On 1 Oct 2002, David M. Karr wrote:
> Date: 01 Oct 2002 21:44:05 -0700
> From: David M. Karr <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Re: cvs commit: jakarta-struts/contrib/struts-el build.xml
>
> >>>>> "Craig" == Craig R McClanahan <[EMAIL PROTECTED]> writes:
>
> Craig> On 1 Oct 2002, David M. Karr wrote:
> >> Date: 01 Oct 2002 21:14:26 -0700
> >> From: David M. Karr <[EMAIL PROTECTED]>
> >> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> >> To: [EMAIL PROTECTED]
> >> Subject: Re: cvs commit: jakarta-struts/contrib/struts-el build.xml
> >>
> >> >>>>> "craigmcc" == craigmcc <[EMAIL PROTECTED]> writes:
> >>
> craigmcc> craigmcc 2002/10/01 18:50:13
> craigmcc> Modified: . build.xml
> craigmcc> contrib/struts-el build.xml
> craigmcc> Log:
> craigmcc> Update the main build.xml file to include struts-el in the new
>"contrib"
> craigmcc> directory, so that the binaries will be included with nightly builds.
> >>
> >> Also, if Struts-EL is being built by default, what will happen if someone
>tries
> >> to build it with a 2.2 servlet.jar?
> >>
>
> Craig> Good point ... it should probably be made conditional based on the
> Craig> presence of Servlet 2.3 (and the JSTL jars, for that matter).
>
> How do you want to handle this, then? Should it be conditional at the
> top-level build, or in the "struts-el" build? It seems like it might be
> easiest to add a 'if="jstl.jar"' to the "dist.contrib" target in the main
> build.xml.
>
That's the best place for it -- people who deliberately choose to use the
contrib/struts-el/build.xml file are going to know that they need Servlet
2.3 anyway.
Craig
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
