Hi Berthold.
On 25/01/2026 10:17, Berthold Stoeger wrote:
On Samstag, 24. Jänner 2026 22:03:08 Mitteleuropäische Normalzeit Michael
Keller wrote:
On 24/01/2026 22:18, Berthold Stoeger wrote:
For example my old dive computer reported this value. Otherwise I would
say
it's a UI issue. One could default to local time offset or to "unknown".
Also, the user should be able to edit this value, obviously.
The user being able to edit the value is an interesting one
I think this is a must. In particular, if we start extracting timezone
information from the divecomputer we have to give the user the chance to "fix"
old and also new dives.
I agree with the user absolutely having to be able to edit the timezone
on the *dive* - if we go down the route of even tracking this. I am with
Dirk there that for all practical purposes this probably isn't worth all
the effort and extra complexities, when all we want is to store the dive
time in local time - whatever that might have been.
The value that I can see is in storing the timezone / time offset that
any dive computer _thought_ it was in, if the dive computer supports it,
to allow the user to trace back what the correct local time is when they
are cleaning up their dive log and reconciling dives that seem to have
an incorrect local time. And this will be easier if the user gets to see
the exact thing that was reported by the dive computer.
- while this
is definitely a good thing for the timezone offset stored for a dive, I
also think there is value in retaining the information provided by the
dive computer as much as possible, to give the user a way to go back to
what was originally reported, even after they have edited and
potentially merged dives.
Fully agree. But IIRC, we don't yet have a place where we display dive-
computer specific data (expect extra_data), or do we?
It's a bit all over the show at the moment - 'Extra Info' is definitely
where we show *only* dive computer specific data - that's why I put the
dive computer reported timezone offset there in
https://github.com/subsurface/subsurface/pull/4689.
But there is dive computer specific information shown in most other tabs
as well, which is making it confusing for technical divers using
multiple dive computers. And to make matters worse, some of them are
user editable, like the dive mode, which if ever changed will likely
turn the data that was downloaded from the dive computer into an
incoherent mess as gas use and resulting tissue loading stop making sense.
Maybe we can rename the "Extra info" tab to "Dive computer info"?
Not a bad idea - but then we should move the other dive computer
specific fields there from where they are now and make them read only,
and potentially create a user editable _dive_ field for the value. But
that's a story for a whole discussion of its own. 😉
Ngā mihi
Michael Keller
_______________________________________________
subsurface mailing list -- [email protected]
To unsubscribe send an email to [email protected]
