On Thu, 4 Feb 2021 09:53:27 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Matthias Perktold has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix JDK-8260687: don't use font inherit for W3C_LENGTH_UNIT
>
> Marked as reviewed by psadhukhan (Reviewer).

I have written automatic test for 
[JDK-8260687](https://bugs.openjdk.java.net/browse/JDK-8260687): Inherited font 
size is smaller than expected when using StyleSheet to add styles. You can find 
it in my JDK-8260687 branch:
https://github.com/aivanov-jdk/jdk/commits/JDK-8260687
There's also a commit which modifies the test from 
[JDK-8257664](https://bugs.openjdk.java.net/browse/JDK-8257664) to run in two 
modes with and without W3C_LENGTH_UNITS.

We have several options:
1. As this PR contains the fix for JDK-8260687, you can cherry-pick the test 
into your branch.
2. I can create a new JBS issue to add the test for JDK-8260687 separately.
3. You can revert the fix in your PR, and I'll add it to the test and then 
raise a new PR to resolve JDK-8260687.

I have no strong preference for any of the options.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2256

Reply via email to