On Thu, 4 Feb 2021 11:34:26 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> I have written automatic test for >> [JDK-8260687](https://bugs.openjdk.java.net/browse/JDK-8260687): Inherited >> font size is smaller than expected when using StyleSheet to add styles. You >> can find it in my JDK-8260687 branch: >> https://github.com/aivanov-jdk/jdk/commits/JDK-8260687 >> There's also a commit which modifies the test from >> [JDK-8257664](https://bugs.openjdk.java.net/browse/JDK-8257664) to run in >> two modes with and without W3C_LENGTH_UNITS. >> >> We have several options: >> 1. As this PR contains the fix for JDK-8260687, you can cherry-pick the test >> into your branch. >> 2. I can create a new JBS issue to add the test for JDK-8260687 separately. >> 3. You can revert the fix in your PR, and I'll add it to the test and then >> raise a new PR to resolve JDK-8260687. >> >> I have no strong preference for any of the options. > >> >> >> I have written automatic test for >> [JDK-8260687](https://bugs.openjdk.java.net/browse/JDK-8260687): Inherited >> font size is smaller than expected when using StyleSheet to add styles. You >> can find it in my JDK-8260687 branch: >> https://github.com/aivanov-jdk/jdk/commits/JDK-8260687 >> There's also a commit which modifies the test from >> [JDK-8257664](https://bugs.openjdk.java.net/browse/JDK-8257664) to run in >> two modes with and without W3C_LENGTH_UNITS. >> >> We have several options: >> >> 1. As this PR contains the fix for JDK-8260687, you can cherry-pick the >> test into your branch. >> >> 2. I can create a new JBS issue to add the test for JDK-8260687 >> separately. >> >> 3. You can revert the fix in your PR, and I'll add it to the test and >> then raise a new PR to resolve JDK-8260687. >> >> >> I have no strong preference for any of the options. > > My preference will be > 1) if @mperktold can pick the test from > https://github.com/aivanov-jdk/jdk/commit/6d0b40db4400dac03567b5cab4ad45b103ea94d0 > and add into this PR > else 2) > @mperktold can you also issue this comment "/issue add JDK-8260687" once > @aivanov-jdk approves this PR. > My preference will be > > 1. if @mperktold can pick the test from > [aivanov-jdk@6d0b40d](https://github.com/aivanov-jdk/jdk/commit/6d0b40db4400dac03567b5cab4ad45b103ea94d0) > and add into this PR > else 2) > @mperktold can you also issue this comment "/issue add JDK-8260687" > once @aivanov-jdk approves this PR. Good! The only thing is that the test file has three commits now: aivanov-jdk@6d0b40d, aivanov-jdk@b50d650, aivanov-jdk@f9e99777 The final version of the test file [BodyInheritedFontSize.java](https://github.com/aivanov-jdk/jdk/blob/f9e997776fe478d99f0bbb6739ded10ec79b4caa/test/jdk/javax/swing/text/html/StyleSheet/8260687/BodyInheritedFontSize.java). Then this PR would include the fixes for two issues, thus the command `/issue add JDK-8260687` would add another resolved bug to the commit. Optionally, issuing the following commands: `/contributor add psadhukhan` `/contributor add aivanov` will add Prasanta and myself as contributors. ------------- PR: https://git.openjdk.java.net/jdk/pull/2256
