OK, thanks for the feedback Ben. I guess if it's not causing problems for any front-ends, there's no point in breaking existing code.
-Ben On Thu, Dec 13, 2012 at 9:31 PM, Ben Morgan <benpmor...@gmail.com> wrote: > G'day Ben, > > From the viewpoint of a frontend developer, I don't really want this change > committed. > > If this change is committed, it will break existing frontends which look for > <!P>, and it produces little or no benefit - <!P> may be invalid, but I > think it will just get ignored. > We already don't really have a good way to generate completely validated > HTML as it is as too many of the existing modules have markup issues (I've > been running across these recently...) > > If it is ever a problem for anyone, I think it's easy enough to instruct > them to do the replacement just like everyone already does. > > God Bless, > Ben > ------------------------------------------------------------- > For I have no pleasure in the death of anyone, > declares the Lord God; so turn, and live.” > Ezekiel 18:32 (ESV) > > > > > On Fri, Dec 14, 2012 at 12:45 PM, <crick...@gmail.com> wrote: >> >> Hello, >> >> I came across the following output in various filters: <!P>. A comment >> in the code talks about this being a silent html comment that the >> front-ends can replace if desired. However, that tag is not valid >> (x)html (I guess it used to be a valid comment). >> >> I'm attaching a patch that replaces <!P> with <!--p-->, so that it's >> valid html or xhtml output, in all the filters where I found <!P>. >> >> If anyone would be willing to commit this, that would be great. Or, if >> there are changes/improvements/problems with the patch, please let me >> know. >> >> Thanks, >> -Ben >> >> _______________________________________________ >> sword-devel mailing list: sword-devel@crosswire.org >> http://www.crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page > > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
