Comment #27 on issue 1766 by smichr: expand(power_base=True) is too
aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Regarding comments:
<<<1778:I think we don't need decimal here and we could use
mpmath, but that's not really important. >>>
Do you mean to not use Decimal to parse the string and return the sign,
mantissa
and exponent? i.e. here:
neg_pow, digits, expt = decimal.Decimal(str(p)).as_tuple()
That's what was being used before. Not knowing how the different routines
parse
strings, I just left that part alone.
<<<And I'm not sure whether sympify() should use nsimplify(). >>>
If you don't, then one may get 333333333333333/100000000000000 rather
than 10/3
for a real 1.3333....
<<<For the hint manager: I think the foo(anything=True) should set anything
else to False(overwrite the defaults). >>>
If you just want to add a single option that isn't already used, then
with this
syntax you would have to turn all the defaults back on again. The 'all'
keyword has
been supplied to do what you are suggesting. If the user wants only
non-default foo
(or can't remember what is default and what is not) then it would be done as
".expand(all=False, foo=True)"
<<<I'm also not sure where to place it, but basic.py (manages calling etc.)
seems more fitting to me than iterables.py. But it also fits to the
utilities
directory.>>>
Should a new utility document be started (like iterables)? What should
it be
called, perhaps just "helpers" or "utilities". Or perhaps until there is
something
else to join the hints manager it could just exist as its own file in the
utilities
directory....Any ideas?
<<<1766: Somewhat large, could be splitted. For example the changes to
facts.py, extract_additively, separate, trigsimp, separatevars, powsimp and
test_simplify. Given the changes were not necessary to make tests pass. >>>
OK, I will look at that.
<<<The doctests for separate() could be preserved. >>>
I was thinking that expand is already well documented but I will look
to see if
there are examples here that aren't in expand. Do you think a wrapper
should have
much documentation of its own? I was thinking not.
<<There are some minor formatting issues like missing spaces around '=' in
variable
assignments (not kwargs of course).>>>
I think I have all those (and some pre-existing ones) cleaned up. We
need a PEP8
tool.... :-)
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
