Comment #28 on issue 1766 by Vinzent.Steinberg: expand(power_base=True) is
too aggressive
http://code.google.com/p/sympy/issues/detail?id=1766
Thanks! Sorry, but I still get failures. :)
1785: The comment above 'def _maxfac' could be a docstring, same for _info,
but leave
it as it is if you want. Don't you think the commented code could be useful
in the
official repository?
1770: Definitely an improvement, could be improved to be consistent and
reuse code,
but that is another issue.
more conservative together: typos: 'extract Add entire add', 'testsing ode
solutions'. The cls(0.9) stuff should be in an earlier commit that broke
this test.
Is _gcdn really only useful for internal stuff? set() == set([]) by the way.
Except-anything-blocks are evil, don't do this. Do you want to use except
(PolynomialError, ZeroDivisionError)? What is the motivation behind areq(),
arne()
and friends? Some changed ODE tests should be broken on several lines,
because they
are much to long.
This is a huge commit, but I assume it can be hardly split?
The non-commutative part looks nice, I'd only add more tests, for example
where it
should not work, like separatevars(n1*n2 + n2*n1) from the docstring.
Attachments:
1766failures.txt 17.3 KB
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
