Maybe it means someone other than the merger has to review it. Aaron Meurer
On Thursday, September 15, 2016, Ondřej Čertík <ondrej.cer...@gmail.com> wrote: > On Thu, Sep 15, 2016 at 6:30 PM, Ondřej Čertík <ondrej.cer...@gmail.com > <javascript:;>> wrote: > > I went there: > > > > https://github.com/sympy/sympy/settings/branches/master > > > > and checked "Require pull request reviews before merging" (including > > administrators), then reviewed & approved this PR: > > > > > > https://github.com/sympy/sympy/pull/11601 > > > > But it says "Required statuses must pass before merging". But all > > statues pass! Then I unchecked "Require pull request reviews before > > merging", and now it can be merged... I think it's a bug at GitHub... > > So I reported it to GitHub Support. > > Ondrej > > > > > > > Ondrej > > > > On Wed, Sep 14, 2016 at 7:41 PM, Aaron Meurer <asmeu...@gmail.com > <javascript:;>> wrote: > >> I can't tell. Like I said, the UI is pretty confusing. We'll have to > play > >> around with it. > >> > >> Aaron Meurer > >> > >> On Wed, Sep 14, 2016 at 9:31 PM, Ondřej Čertík <ondrej.cer...@gmail.com > <javascript:;>> > >> wrote: > >>> > >>> I was just about to post here: > >>> > >>> > >>> https://github.com/blog/2256-a-whole-new-github-universe- > announcing-new-tools-forums-and-features > >>> > >>> Will this make it obvious when a PR is waiting for the author to do > >>> more work, and can the author "flip a switch" and we can quickly see > >>> that the work got done? > >>> > >>> Ondrej > >>> > >>> On Wed, Sep 14, 2016 at 12:19 PM, Aaron Meurer <asmeu...@gmail.com > <javascript:;>> wrote: > >>> > So it looks like GitHub has added direct support for this. The UI so > far > >>> > is > >>> > a little confusing. Hopefully they will improve that. > >>> > > >>> > Aaron Meurer > >>> > > >>> > On Thu, Sep 8, 2016 at 3:59 PM, Jason Moore <moorepa...@gmail.com > <javascript:;>> > >>> > wrote: > >>> >> > >>> >> I agree that closing is not a good idea. > >>> >> > >>> >> > >>> >> Jason > >>> >> moorepants.info > >>> >> +01 530-601-9791 > >>> >> > >>> >> On Thu, Sep 8, 2016 at 12:15 PM, Ondřej Čertík > >>> >> <ondrej.cer...@gmail.com <javascript:;>> > >>> >> wrote: > >>> >>> > >>> >>> On Thu, Sep 8, 2016 at 12:09 PM, Aaron Meurer <asmeu...@gmail.com > <javascript:;>> > >>> >>> wrote: > >>> >>> > I'm not a fan of that. Closing gives people the impression that > the > >>> >>> > pull > >>> >>> > request is being rejected. > >>> >>> > >>> >>> I know. GitHub should improve this workflow a lot. > >>> >>> > >>> >>> Ondrej > >>> >>> > >>> >>> -- > >>> >>> You received this message because you are subscribed to the Google > >>> >>> Groups > >>> >>> "sympy" group. > >>> >>> To unsubscribe from this group and stop receiving emails from it, > send > >>> >>> an > >>> >>> email to sympy+unsubscr...@googlegroups.com <javascript:;>. > >>> >>> To post to this group, send email to sympy@googlegroups.com > <javascript:;>. > >>> >>> Visit this group at https://groups.google.com/group/sympy. > >>> >>> To view this discussion on the web visit > >>> >>> > >>> >>> https://groups.google.com/d/msgid/sympy/CADDwiVBecdOpF% > 3D3qqgooaiZwepf_%2Baur7kiC-Ufu25p_6upyHQ%40mail.gmail.com. > >>> >>> For more options, visit https://groups.google.com/d/optout. > >>> >> > >>> >> > >>> >> -- > >>> >> You received this message because you are subscribed to the Google > >>> >> Groups > >>> >> "sympy" group. > >>> >> To unsubscribe from this group and stop receiving emails from it, > send > >>> >> an > >>> >> email to sympy+unsubscr...@googlegroups.com <javascript:;>. > >>> >> To post to this group, send email to sympy@googlegroups.com > <javascript:;>. > >>> >> Visit this group at https://groups.google.com/group/sympy. > >>> >> To view this discussion on the web visit > >>> >> > >>> >> https://groups.google.com/d/msgid/sympy/CAP7f1Agjqo08YJiLcu19- > xmW9okttHOn9rm2gth-rF1Y772XJA%40mail.gmail.com. > >>> >> > >>> >> For more options, visit https://groups.google.com/d/optout. > >>> > > >>> > > >>> > -- > >>> > You received this message because you are subscribed to the Google > >>> > Groups > >>> > "sympy" group. > >>> > To unsubscribe from this group and stop receiving emails from it, > send > >>> > an > >>> > email to sympy+unsubscr...@googlegroups.com <javascript:;>. > >>> > To post to this group, send email to sympy@googlegroups.com > <javascript:;>. > >>> > Visit this group at https://groups.google.com/group/sympy. > >>> > To view this discussion on the web visit > >>> > > >>> > https://groups.google.com/d/msgid/sympy/CAKgW%3D6L%2BQ8Js% > 2BAANRSL7ebqKtAujzdYyq03eQr76JeBqdwYDew%40mail.gmail.com. > >>> > > >>> > For more options, visit https://groups.google.com/d/optout. > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > Groups > >>> "sympy" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > an > >>> email to sympy+unsubscr...@googlegroups.com <javascript:;>. > >>> To post to this group, send email to sympy@googlegroups.com > <javascript:;>. > >>> Visit this group at https://groups.google.com/group/sympy. > >>> To view this discussion on the web visit > >>> https://groups.google.com/d/msgid/sympy/CADDwiVA_ > tKqLrRfxHNgGQ6rVSQqGi4pA%3DVHJNNcUcdO25rpY9A%40mail.gmail.com. > >>> For more options, visit https://groups.google.com/d/optout. > >> > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "sympy" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an > >> email to sympy+unsubscr...@googlegroups.com <javascript:;>. > >> To post to this group, send email to sympy@googlegroups.com > <javascript:;>. > >> Visit this group at https://groups.google.com/group/sympy. > >> To view this discussion on the web visit > >> https://groups.google.com/d/msgid/sympy/CAKgW% > 3D6JghYv4nA3fN8WPqRM5Qd4PjVxD3EK-DKLL2DXx_3KdYw%40mail.gmail.com. > >> > >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com <javascript:;>. > To post to this group, send email to sympy@googlegroups.com <javascript:;> > . > Visit this group at https://groups.google.com/group/sympy. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/sympy/CADDwiVCVx8cAPWDk70swbYf%3DDWkbx%3D9%3DSYUf% > 3Dx0pdDmXyxeHHA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6%2BXuQnVWt-y0g-dgmXt%3DQhziWS%3DX8r5uKnrWF2OOuC1Kg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
