On Mon, 2008-01-07 at 00:29 +0000, Jonny Lamb wrote:
> On Sun, 2008-01-06 at 21:35 +0000, Dr J A Gow wrote:
> > I think this issue may always be a problem unless we provide a script in
> > the sync-engine distribution, something like 'install-plugins.py' which
> > will (re)generate the appropriate file/symlink in the OpenSync plugin
> > directory. We could run this post-install, and instruct users to run
> > this file if they delete and reinstall OpenSync.
> 
> What do you think of the attached?
> 
> I feel the opensync-plugin*.py files should be renamed to something
> better too -- synce-opensync-plugin*.py even?

All done in the latest batch of commits. Note that I modified your patch
to copy the plugins, rather than move them. This prevents the possible
loss of the plugin when a user nukes their OpenSync install for any
reason (could happen when using experimental versions particularly). All
they have to do now is re-run synce-install-plugins and all will be
well. I have tested with OpenSync 0.3x and will test with OpenSync 0.2x
tomorrow when I get back to work.

Setup.py will need updating as I have cleaned up the sync-engine root
somewhat. Both plugins will need copying across during installation of
the archive and they should reside in the sync-engine distribution
somewhere (not just in the OpenSync dir) to avoid the above problem.


        John.



Other changes (excerpt from changelog):

07/12/2007 - 204100 Dr J A Gow
------------------------------

Changed plugin names to a more sensible scheme and moved them to a 
'plugins' directory from which they can be copied to the OpenSync
working directory. Had to use 'synce-opensync-plugin-2x' etc, as the
OpenSync plugin architecture can not handle periods in the filenames.
Removed dependency of file-sync code on absolute paths and modified 
the base config.xml file to include sensible defaults. Moved the config
file to a subdirectory 'config' as sync-engine root was getting
cluttered. Applied patch from Jonny Lamb including new
synce-install-plugins. Modified this script to move rather than copy (in
case a user hoses their OpenSync installation we then do not lose the
plugin as well). Also corrected the python plugins directory (appears as
opensync-1.0/python-plugins not opensync-1.0/plugins/python-plugins).
The script can be re-run at any time to refresh the plugins in the
OpenSync directory.

Setup.py needs updating to reflect these changes.





-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel

Reply via email to