On Fri, Aug 19, 2011 at 6:10 PM, Chris Kühl <[email protected]> wrote:
> On Thu, Aug 18, 2011 at 4:03 PM, Patrick Ohly <[email protected]> wrote:
>
> What can I say? I like variety. ;) Fixed.
>
>> --- a/test/test-dbus.py
>> +++ b/test/test-dbus.py
>> @@ -53,6 +53,10 @@ monitor = ["dbus-monitor"]
>>  # primarily for XDG files, but also other temporary files
>>  xdg_root = "temp-test-dbus"
>>  configName = "dbus_unittest"
>> +# for bluetooth tests. replace with values from your test device.
>> +bt_device_mac = "D4:5D:42:73:E4:6C"
>> +bt_device_fingerprint = "Nokia 5230"
>> +bt_device_name = "Nokia 5230a"
>>
>> Replace how? By editing the script? I know that I have set a bad
>> precedent by using the same approach for enabling gdb, but that is rare.
>> A better mechanism for the device would be useful - command line
>> parameter or env variable? Or perhaps better simulate a desktop
>> environment with various paired Bluetooth devices by registering a mock
>> org.bluez implementation on the D-Bus session bus and using it in
>> syncevo-dbus-server when a certain env variable is set? See
>> DBUS_TEST_CONNMAN for an example.
>>
>
> Ok, I see. I'll get this changed. Not in right now, though.
>

This is also done now.  I think this is what you intended.

The bluetooth-device-id-merge-prep is ready to be reviewed now.

Cheers,
Chris
_______________________________________________
SyncEvolution mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution

Reply via email to