2011/8/26 Patrick Ohly <[email protected]>: > On Mi, 2011-08-24 at 14:46 +0200, Chris Kühl wrote: >> The bluetooth-device-id-merge-prep is ready to be reviewed now. > > I've merged the D-Bus server reorganization, dbus-test and > bluetooth-device-id-merge-prep branches. I fixed some minor problems > found with -Werror -Wall.
Great! > > Attached an updated revision of the bluetooth-device-id-inspector.py > script. Should we maintain it in SyncEvolution? > Makes sense. Should it go in test or should we create a tools/utilities directory? > My changes: > - more information for the user > - allow the user to skip devices > - don't include vendor in example product name > - skip devices which have PNPINFO_UUID information, but are not > online at the moment (script used to abort with an exception) Yeah, I ran into this after committing and never got around to updating. Thanks. > - write the user provided vendor/model information into the file > even if PNPINFO_UUID information isn't supported > > The last point avoids the situation where the user is asked to send you > a file which says "This phone does not support Device ID profile" > without telling you what phone it is ;-) > Ah right. ;) > Do we want to gather information about that? I think we should for the > sake of completeness, although I am not sure what to do with it in that > case. > Yes, I agree. It may be of interest to know which phones don't support this feature, if only to give us some insight into what percentage of phones do support the device id profile. > Here's an example run: > > Device name: localhost.localdomain-0 > MAC Address: 00:22:43:AF:07:0D > Supports SyncML. > What company makes this phone? (examples: Nokia, Sony Ericsson), empty to > skip: > Device name: K750i > MAC Address: 00:0E:07:B1:90:17 > Supports SyncML. > Looking up device information... > Failed, skipping device: org.bluez.Error.ConnectionAttemptFailed: Host is > down > Device name: 6310i > MAC Address: 00:60:57:33:6C:0C > What company makes this phone? (examples: Nokia, Sony Ericsson), empty to > skip: Nokia > What is the model of this phone? (example: N900, K750i), empty to skip: > 6310i > Thanks, please send the file syncevo-phone-info-[6310i].txt to blixtra [at] > gmail.com > Device name: Nokia N70 > MAC Address: 00:17:4B:1D:28:B2 > Supports SyncML. > What company makes this phone? (examples: Nokia, Sony Ericsson), empty to > skip: Nokia > What is the model of this phone? (example: N900, K750i), empty to skip: N70 > Thanks, please send the file syncevo-phone-info-[N70].txt to blixtra [at] > gmail.com > Device name: Nokia N900 > MAC Address: 80:50:1B:BE:AA:2B > Supports SyncML. > What company makes this phone? (examples: Nokia, Sony Ericsson), empty to > skip: Nokia > What is the model of this phone? (example: N900, K750i), empty to skip: N900 > Thanks, please send the file syncevo-phone-info-[N900].txt to blixtra [at] > gmail.com > Device Name: Nokia N97 mini > MAC Address: A0:4E:04:1E:AD:30 > Supports SyncML. > Looking up device information... > What company makes this phone? (examples: Nokia, Sony Ericsson), empty to > skip: Nokia > What is the model of this phone? (example: N900, K750i), empty to skip: N97 > mini > Device name: Nokia 7100s-2 > MAC Address: C8:97:9F:5D:B7:FB > Supports SyncML. > Looking up device information... > Failed, skipping device: org.bluez.Error.ConnectionAttemptFailed: Host is > down > > Of the various Nokia phones, only some supported the Device ID profile > and I had only turned on the N97. All resulting files also attached. > > When I tried this in combination with the GTK sync-ui, I found that my > "Nokia N97" (user chosen name) was sometimes shown as "Nokia", sometimes > as "Nokia N97" in the UI. > > Chris, I suspect that I gave you wrong guidance about the use use of > deviceName/peerName, or we have to extend the semantic. According to the > D-Bus API docs: > > * deviceName: device template: the device name that the template > is for (copied verbatim from that device) > * templateName: device template: string identifying the class of > devices the templates works for, like "Nokia S40"; meant to be > shown to users; optional, fall back to first entry in > fingerPrint if not set > > Now the syncevo-dbus-server sends deviceName=Nokia, templateName=Nokia > and peerName=Nokia N97 mini. > > I think it should send: > * deviceName: the vendor/model information if available, otherwise > the user-configurable device name (can't be empty, because > traditionally it wasn't describe as optional) Right, I can make this change. But when you say "vendor/model is available" you mean when the product and not *just* the vendor is in the lookup table, right? That would make sense to me. > * templateName: the "templateName" from the template, as it used > to (see above) I wasn't aware I changed this. I'll take a closer look. > * peerName: the user-configurable name (optional, old > syncevo-dbus-servers do not provide it) > > The syncevo-dbus-server's use of deviceName needs to be adapted to meet > this revised definition. > Ok. I'll assume my above interpretation is correct until told differently. Thanks for getting this merged. Cheers, Chris _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
