2012/11/5 Carlos López González <[email protected]>

> We should change the code to use the localized version of the parameter
> name instead of the type name when the English version of Synfig Studio

...


> when running the non translated version of Synfig Studio, must be other
> than the literal string of the type.



It seems the cause is in ValueBase::type_local_name [
https://github.com/synfig/synfig/blob/master/synfig-core/src/synfig/value.cpp#L317
],

String

ValueBase::type_local_name(Type id)

{

        return dgettext("synfig",type_name(id).c_str());

}





~ yu

--
No one will come, Yu has to make it happen by Yu-self.



2012/11/19 Yu Chen <[email protected]>

> Thanks Carlos,
>
> That's right to don't touch synfig core code for the UI changes. To solve
> it, I just insert a new line to canvastreestore.cpp after L210[1]:
>
>     if(stype== "bline_point") {stype=_("spline_point");}
>
>
> Let's take a look at value.cpp L270[2], all the types are marked as
> translatable strings. Shall we remove them from synfig core code to synfig
> studio just following the change of "spline_point" type?
>
>
>
>
> [1]
> https://github.com/synfig/synfig/blob/master/synfig-studio/src/gui/trees/canvastreestore.cpp#L210
> [2]
> https://github.com/synfig/synfig/blob/master/synfig-core/src/synfig/value.cpp#L270
>
> ~ yu
>
> --
> No one will come, Yu has to make it happen by Yu-self.
>
>
>
> 2012/11/5 Carlos López González <[email protected]>
>
>>  There is not problem in open a sif file created with any translated
>> version of SynfigStudio using the translated one or the native English one.
>> The key thing is in the cell renderer that uses the parameter keyname
>> when the translatable string is not available. We should change the code to
>> use the localized version of the parameter name instead of the type name
>> when the English version of Synfig Studio (the one that is not using any
>> translatable string is in use.
>> The code is this in canvastreestore.cpp
>> Notice in this line how the "Static" label is added to the type when the
>> attribute is not animated:
>>
>> https://github.com/synfig/synfig/blob/master/synfig-studio/src/gui/trees/canvastreestore.cpp#L194
>> Somehow in those portions of code, the selected strings to use when
>> running the non translated version of Synfig Studio, must be other than the
>> literal string of the type.
>>
>> So yes, some kind of code has to be done to make the non translated
>> version of Synfig Studio to use the string but there is not need to modify
>> the synfig core to read or parse "translated types". That would be a bad
>> idea I think.
>>
>> Cheers, Carlos
>>
>>
>>
>> ------------------------------------------------------------------------------
>> LogMeIn Central: Instant, anywhere, Remote PC access and management.
>> Stay in control, update software, and manage PCs from one command center
>> Diagnose problems and improve visibility into emerging IT issues
>> Automate, monitor and manage. Do more in less time with Central
>> http://p.sf.net/sfu/logmein12331_d2d
>> _______________________________________________
>> Synfig-devl mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>
>>
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Synfig-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to