Hi!
I've added several comments on github. Please check out them.
Please don't get me wrong. I'm looking just for excellence in our behavior.
Good work Jcome!
Greetings
Carlos
2012/11/27 Yu Chen <jco...@gmail.com>
> Hi All,
>
> The code is ready for test,
> https://github.com/jcome/synfig/tree/terms-rework
>
> You can clone to build and test it if it interests you.
>
> And the new icons in the above rep are not decided yet, I am working on it.
>
> Cheers!
> Yu
>
> ~ yu
>
> --
> No one will come, Yu has to make it happen by Yu-self.
>
>
>
> 2012/11/21 Carlos López González <genet...@gmail.com>
>
>> Hi Yu,
>> Yes, that would be the best solution.
>> Make those strings translatable in the right place, not in the type_name
>> function. You can remove the translatable strings marks (the N_(...)
>> macros) and add a switch case code inside the type_local_name, repeating
>> the types again. It is not the ideal solution but it should work. It would
>> obligate us to keep the two list in synchronization when further types are
>> added (i.e. bone).
>> Cheers!
>> Carlos
>>
>>
>> 2012/11/20 Yu Chen <jco...@gmail.com>
>>
>>> Hi Carlos,
>>>
>>> ValueBase::type_name() is used when saving canvas,and it will be
>>> written in sif file, and it is used in savecanvas.cpp only.
>>> How about to make it non-localizable string? And instead, we can make
>>> some changes to make ValueBase::type_local_name()
>>> localizable, in UI part we should always use type_local_name.
>>>
>>> Cheers!
>>> Yu
>>>
>>> ~ yu
>>>
>>> --
>>> No one will come, Yu has to make it happen by Yu-self.
>>>
>>>
>>>
>>> 2012/11/19 Carlos López González <genet...@gmail.com>
>>>
>>>> Hi Yu,
>>>>
>>>> I don't know right now what's the best solution for that. I think that
>>>> we are trying to fix the fact that some of the translatable strings are
>>>> types and then we are worried that they are shown on the GUI when using the
>>>> non translated version of Synfig Studio.
>>>> Your proposal is to "rename" those strings when using a non translated
>>>> version of Synfig Studio. In fact anyone should never use a untranslated
>>>> version of Synfig Studio. Even there is a Englisk (UK) version of the
>>>> translated strings in Transifex. I hope that in the future when Synfig
>>>> Studio is installed it should install only a translated version and fall
>>>> back to the translated English version in any case.
>>>>
>>>> Anyway, for me your proposal is OK but it might worth to think on a
>>>> expandable method to translate the string instead of a if()else() method on
>>>> each line.
>>>>
>>>> Possibly a String CanvasTreeStore::rename_type_name(String &type_name)
>>>> would be enough and enclose all the string comparison there, so the code
>>>> would be more compact and revisable after all.
>>>>
>>>> In that case, any occurrence of ValueBase::type_name should be reviewed
>>>> because when it is used referring to the renamed type_name it should use
>>>> the rename function and when it is used to refer to the internals of a sif
>>>> file it shouldn't be renamed. Review the usage of ValueBase::type_name is a
>>>> needed task to be sure that your proposal is fine.
>>>>
>>>> Thanks!
>>>>
>>>> 2012/11/19 Yu Chen <jco...@gmail.com>
>>>>
>>>>> Thanks Carlos,
>>>>>
>>>>> That's right to don't touch synfig core code for the UI changes. To
>>>>> solve it, I just insert a new line to canvastreestore.cpp after L210[1]:
>>>>>
>>>>> if(stype== "bline_point") {stype=_("spline_point");}
>>>>>
>>>>>
>>>>> Let's take a look at value.cpp L270[2], all the types are marked as
>>>>> translatable strings. Shall we remove them from synfig core code to synfig
>>>>> studio just following the change of "spline_point" type?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> [1]
>>>>> https://github.com/synfig/synfig/blob/master/synfig-studio/src/gui/trees/canvastreestore.cpp#L210
>>>>> [2]
>>>>> https://github.com/synfig/synfig/blob/master/synfig-core/src/synfig/value.cpp#L270
>>>>>
>>>>> ~ yu
>>>>>
>>>>> --
>>>>> No one will come, Yu has to make it happen by Yu-self.
>>>>>
>>>>>
>>>>>
>>>>> 2012/11/5 Carlos López González <genet...@gmail.com>
>>>>>
>>>>>> There is not problem in open a sif file created with any translated
>>>>>> version of SynfigStudio using the translated one or the native English
>>>>>> one.
>>>>>> The key thing is in the cell renderer that uses the parameter keyname
>>>>>> when the translatable string is not available. We should change the code
>>>>>> to
>>>>>> use the localized version of the parameter name instead of the type name
>>>>>> when the English version of Synfig Studio (the one that is not using any
>>>>>> translatable string is in use.
>>>>>> The code is this in canvastreestore.cpp
>>>>>> Notice in this line how the "Static" label is added to the type when
>>>>>> the attribute is not animated:
>>>>>>
>>>>>> https://github.com/synfig/synfig/blob/master/synfig-studio/src/gui/trees/canvastreestore.cpp#L194
>>>>>> Somehow in those portions of code, the selected strings to use when
>>>>>> running the non translated version of Synfig Studio, must be other than
>>>>>> the
>>>>>> literal string of the type.
>>>>>>
>>>>>> So yes, some kind of code has to be done to make the non translated
>>>>>> version of Synfig Studio to use the string but there is not need to
>>>>>> modify
>>>>>> the synfig core to read or parse "translated types". That would be a bad
>>>>>> idea I think.
>>>>>>
>>>>>> Cheers, Carlos
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> LogMeIn Central: Instant, anywhere, Remote PC access and management.
>>>>>> Stay in control, update software, and manage PCs from one command
>>>>>> center
>>>>>> Diagnose problems and improve visibility into emerging IT issues
>>>>>> Automate, monitor and manage. Do more in less time with Central
>>>>>> http://p.sf.net/sfu/logmein12331_d2d
>>>>>> _______________________________________________
>>>>>> Synfig-devl mailing list
>>>>>> Synfig-devl@lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>>> web console. Get in-depth insight into apps, servers, databases,
>>>>> vmware,
>>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>>> Pricing starts from $795 for 25 servers or applications!
>>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>>>
>>>>> _______________________________________________
>>>>> Synfig-devl mailing list
>>>>> Synfig-devl@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Carlos
>>>> http://synfig.org
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>> Pricing starts from $795 for 25 servers or applications!
>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>> _______________________________________________
>>>> Synfig-devl mailing list
>>>> Synfig-devl@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Monitor your physical, virtual and cloud infrastructure from a single
>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>> Pricing starts from $795 for 25 servers or applications!
>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>> _______________________________________________
>>> Synfig-devl mailing list
>>> Synfig-devl@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>>
>>>
>>
>>
>> --
>> Carlos
>> http://synfig.org
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Monitor your physical, virtual and cloud infrastructure from a single
>> web console. Get in-depth insight into apps, servers, databases, vmware,
>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> Pricing starts from $795 for 25 servers or applications!
>> http://p.sf.net/sfu/zoho_dev2dev_nov
>> _______________________________________________
>> Synfig-devl mailing list
>> Synfig-devl@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>>
>>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Synfig-devl mailing list
> Synfig-devl@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>
>
--
Carlos
http://synfig.org
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl
