On Tue, Nov 30, 2010 at 02:43:48AM +0500, Alexandr Shadchin wrote: > On Mon, Nov 29, 2010 at 08:58:31PM +0000, Nicholas Marriott wrote: > > Hi > > > > Sorry for the delay again :-/. > > > > On Tue, Nov 23, 2010 at 04:10:29PM +0500, Alexandr Shadchin wrote: > > > On Mon, Nov 22, 2010 at 09:44:14PM +0000, Nicholas Marriott wrote: > > > > Hi Alexandr > > > > > > > > This works fine for me with both with X and wsmoused. > > > > > > > > A few things: > > > > > > > > - Did you deliberately remove WSMOUSEIO_SRES? > > > > > > > > > > Yes. WSMOUSEIO_SRES in Xenocara not used, in src - only wsmoused and > > > wsconsctl, > > > in drivers - only in pms. I think that now do not need WSMOUSEIO_SRES. > > > > Hmm, I don't understand. Are you saying nobody should use wsconsctl > > mouse.resolution anymore? > > > > pms only works with WSMOUSEIO_SRES (this only ps\2 mouse) > Other drivers do not use WSMOUSEIO_SRES, so mouse.resolution irrelevant. > X reset mouse.resolution. > X open mouse -> ... -> pms_enable -> pms_change_state -> > -> pms_reset (set default resolution) :-) > > Only wsmoused uses WSMOUSEIO_SRES (only ps\2 mouse). > Therefore, I am more than sure that nobody uses mouse.resolution
Well, I don't use it so I don't have strong feelings about it, but it does work for PS/2 mice and it seems that it would be useful for anyone using wsmoused (although there probably aren't many people). Would it be so hard to leave it, and if it is really not needed remove it entirely as a separate change? Otherwise aside from the char -> signed char change I mentioned the diff is fine with me. > > -- > Alexandr Shadchin
