On Wed, Dec 1, 2010 at 3:33 PM, Mark Kettenis <mark.kette...@xs4all.nl>
wrote:
>> Date: Tue, 30 Nov 2010 21:33:41 +0500
>> From: Alexandr Shadchin <alexandr.shadc...@gmail.com>
>>
>> On Mon, Nov 29, 2010 at 10:08:22PM +0000, Nicholas Marriott wrote:
>> >
>> > Well, I don't use it so I don't have strong feelings about it, but it
>> > does work for PS/2 mice and it seems that it would be useful for anyone
>> > using wsmoused (although there probably aren't many people).
>> >
>> > Would it be so hard to leave it, and if it is really not needed remove
>> > it entirely as a separate change?
>> >
>> > Otherwise aside from the char -> signed char change I mentioned the diff
>> > is fine with me.
>> >
>>
>> 1) fix char -> signed char
>> 2) Returned WSMOUSEIO_SRES
>>
>> --
>> Alexandr Shadchin
>>
>> Index: pms.c
>> ===================================================================
>> RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
>> retrieving revision 1.14
>> diff -u -p -r1.14 pms.c
>> --- pms.c B B 15 Nov 2010 20:25:31 -0000 B B B 1.14
>> +++ pms.c B B 30 Nov 2010 16:26:20 -0000
>> @@ -52,14 +66,38 @@ struct pms_softc { B B B B B B B B /* driver
status inf
>> B #define PMS_STATE_SUSPENDED B 2
>>
>> B B B int poll;
>> - B B int intelli;
>> B B B int inputstate;
>> - B B u_int buttons, oldbuttons; B B B /* mouse button status */
>> - B B signed char dx, dy;
>> +
>> + B B struct pms_protocol protocol;
>> +
>> + B B unsigned char packet[8];
>
> Small, and perhaps even irrelevant nit: we tend to use 'u_char'
> instead of 'unsigned char' in BSD-specific interfaces. B Saves a few
> bytes in the source file and is consistent with the usage of 'u_int'
> in this file.
>
> Feel free to ignore.
>
>
ok, I like more with u_char.
--
Alexandr Shadchin
