> Date: Tue, 30 Nov 2010 21:33:41 +0500 > From: Alexandr Shadchin <[email protected]> > > On Mon, Nov 29, 2010 at 10:08:22PM +0000, Nicholas Marriott wrote: > > > > Well, I don't use it so I don't have strong feelings about it, but it > > does work for PS/2 mice and it seems that it would be useful for anyone > > using wsmoused (although there probably aren't many people). > > > > Would it be so hard to leave it, and if it is really not needed remove > > it entirely as a separate change? > > > > Otherwise aside from the char -> signed char change I mentioned the diff > > is fine with me. > > > > 1) fix char -> signed char > 2) Returned WSMOUSEIO_SRES > > -- > Alexandr Shadchin > > Index: pms.c > =================================================================== > RCS file: /cvs/src/sys/dev/pckbc/pms.c,v > retrieving revision 1.14 > diff -u -p -r1.14 pms.c > --- pms.c 15 Nov 2010 20:25:31 -0000 1.14 > +++ pms.c 30 Nov 2010 16:26:20 -0000 > @@ -52,14 +66,38 @@ struct pms_softc { /* driver status inf > #define PMS_STATE_SUSPENDED 2 > > int poll; > - int intelli; > int inputstate; > - u_int buttons, oldbuttons; /* mouse button status */ > - signed char dx, dy; > + > + struct pms_protocol protocol; > + > + unsigned char packet[8];
Small, and perhaps even irrelevant nit: we tend to use 'u_char' instead of 'unsigned char' in BSD-specific interfaces. Saves a few bytes in the source file and is consistent with the usage of 'u_int' in this file. Feel free to ignore.
