Op Wed, 27 Aug 2014 20:50:34 +0200 schreef Miod Vallat <m...@online.fr>:
Why not keep the softdep flag when updating rw->ro?
E.g. via mount -ur /usr/obj
fstab(5) already allows ro+softdep.

Because if we were to apply this diff, there would be no way to switch
from rw+softdep to rw.

That was already broken; rw->rw is not affected as per the enclosing if-block.

I just tried this on 5.5 (GENERIC, without my diff):
# mount -vu -onosoftdep /usr/obj/
/dev/wd0f on /home type ffs (rw, local, noatime, nodev, nosuid, softdep, ctime=Thu Aug 28 11:04:07 2014)

And then after un-mounting and re-mounting without softdep:
# mount -vu -osoftdep /usr/obj/
/dev/sd0f on /usr/obj type ffs (rw, local, nodev, nosuid, ctime=Thu Aug 28 11:12:57 2014)

So, currently it doesn't seem possible to turn softdep on or off with an rw mount. My diff doesn't change that.


--
(Remove the obvious prefix to reply privately.)
Gemaakt met Opera's e-mailprogramma: http://www.opera.com/mail/

Reply via email to