On Sun, Aug 13, 2023 at 10:02:26PM -0700, Kevin Williams wrote:
> What about giving sysupgrade the same verbosity options as fw_update?
> This would mean -v and -vv I sysupgrade would pass through the same
> options to fw_update.
>
> And for the installer, maybe another question: “Verbose download &
> install progress?” Or no, as default.

I think it's overengineering for such simple task.

Regarding installer - probably simple notice about what's happening will
be enough too - user will either understand that some network activity
in process or will get immediate message that installer can't resolve
whatever etc.

Proposed patch:

diff /usr/src
commit - 8afcf90fb39e4a84606e93137c2b6c20f44312cb
path + /usr/src
blob - 4386ec9873c433a99fa83b9a9091c06bd9527777
file + distrib/miniroot/install.sub
--- distrib/miniroot/install.sub
+++ distrib/miniroot/install.sub
@@ -3008,7 +3008,9 @@ __EOT
 fi
 __EOT
 
-       [ -x /mnt/usr/sbin/fw_update ] && DESTDIR=/mnt /mnt/usr/sbin/fw_update
+       [ -x /mnt/usr/sbin/fw_update ] &&
+               echo "Downloading firmware..." &&
+               DESTDIR=/mnt /mnt/usr/sbin/fw_update
 
        if [[ -f $_kernel_dir.tgz ]]; then
                echo -n "Relinking to create unique kernel..."

Reply via email to